Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obselete snapshots #4275

Merged
merged 1 commit into from
Feb 11, 2022
Merged

chore: remove obselete snapshots #4275

merged 1 commit into from
Feb 11, 2022

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

remove obselete snapshots.

Breaking Changes

None

Additional Info

No

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #4275 (07d9fa7) into master (12fe530) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4275   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files          14       14           
  Lines        1541     1541           
  Branches      590      590           
=======================================
  Hits         1423     1423           
  Misses        109      109           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12fe530...07d9fa7. Read the comment docs.

@snitin315 snitin315 merged commit 9d0f4cd into master Feb 11, 2022
@snitin315 snitin315 deleted the rm-old-snapshots branch February 11, 2022 13:56
@alexander-akait
Copy link
Member

@snitin315

This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with --detectOpenHandles to troubleshoot this issue.
Terminate batch job (Y/N)?

Looks like we don't close something, even on fail, it can be problem

@alexander-akait
Copy link
Member

We need to find how to verbose Test Suites: 1 skipped, 73 passed, 73 of 74 total and understand where we don't close it

@snitin315
Copy link
Member Author

looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants