Skip to content

refactor: remove client.transport in favor of client.webSocketTransport #3525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 13, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Jul 13, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

remove client.transport in favor of client.webSocketTransPort

Breaking Changes

yes, client.transport was removed in favor of client.webSocketTransPort

Additional Info

None

@snitin315 snitin315 changed the title refactor: remove client.transport in favor of `client.webSocketTran… refactor: remove client.transport in favor of client.webSocketTransPort Jul 13, 2021
@alexander-akait
Copy link
Member

Let's fix CI

@snitin315 snitin315 changed the title refactor: remove client.transport in favor of client.webSocketTransPort refactor: remove client.transport in favor of client.webSocketTransport Jul 13, 2021
@snitin315 snitin315 force-pushed the web-socket-transport branch from 77c3581 to 5dc7c29 Compare July 13, 2021 11:13
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #3525 (5dc7c29) into master (9a1edc1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3525   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files          20       20           
  Lines        1287     1287           
  Branches      426      426           
=======================================
  Hits         1211     1211           
  Misses         71       71           
  Partials        5        5           
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
lib/utils/DevServerPlugin.js 99.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1edc1...5dc7c29. Read the comment docs.

@alexander-akait alexander-akait merged commit 39a07e4 into master Jul 13, 2021
@alexander-akait alexander-akait deleted the web-socket-transport branch July 13, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants