-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Refactor remove entry options in favor manual #3494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor remove entry options in favor manual #3494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3494 +/- ##
==========================================
- Coverage 94.42% 94.28% -0.15%
==========================================
Files 20 20
Lines 1291 1294 +3
Branches 417 419 +2
==========================================
+ Hits 1219 1220 +1
- Misses 67 69 +2
Partials 5 5
Continue to review full report at Codecov.
|
c7c1b3a
to
5ccfa4e
Compare
I will update the migration guide after the merge. |
We need couple test here, I will add them |
deb8b06
to
1c8757b
Compare
For Bugs and Features; did you add new tests?
WIP
Motivation / Use-Case
Remove
needClientEntry
andhotEntry
Breaking Changes
Yes
Additional Info
These are useless options now they do not allow to filter entries, and in most cases are not needed, you can disable
hot
entry usinghot: false
, and client entry usingclient: false
(this PR), for custom configuration when you don't need reload some entries (it is rare case and mostly workarounds) you can use manual setup hot and client entry I will add tests cases here in enar future and provide example how you can do it