Skip to content

Refactor remove entry options in favor manual #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 12, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

WIP

Motivation / Use-Case

Remove needClientEntry and hotEntry

Breaking Changes

Yes

Additional Info

These are useless options now they do not allow to filter entries, and in most cases are not needed, you can disable hot entry using hot: false, and client entry using client: false (this PR), for custom configuration when you don't need reload some entries (it is rare case and mostly workarounds) you can use manual setup hot and client entry I will add tests cases here in enar future and provide example how you can do it

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #3494 (6b94f09) into master (3067392) will decrease coverage by 0.14%.
The diff coverage is 95.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3494      +/-   ##
==========================================
- Coverage   94.42%   94.28%   -0.15%     
==========================================
  Files          20       20              
  Lines        1291     1294       +3     
  Branches      417      419       +2     
==========================================
+ Hits         1219     1220       +1     
- Misses         67       69       +2     
  Partials        5        5              
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
client-src/index.js 86.79% <50.00%> (-1.45%) ⬇️
client-src/utils/reloadApp.js 84.61% <100.00%> (+2.00%) ⬆️
lib/Server.js 93.70% <100.00%> (+0.01%) ⬆️
lib/utils/DevServerPlugin.js 99.27% <100.00%> (+0.65%) ⬆️
lib/utils/normalizeOptions.js 97.19% <100.00%> (+0.01%) ⬆️
lib/servers/WebsocketServer.js 89.47% <0.00%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3067392...6b94f09. Read the comment docs.

anshumanv
anshumanv previously approved these changes Jun 29, 2021
@alexander-akait alexander-akait force-pushed the refactor-remove-entry-options-in-favor-manual branch from c7c1b3a to 5ccfa4e Compare July 2, 2021 18:00
snitin315
snitin315 previously approved these changes Jul 2, 2021
@snitin315
Copy link
Member

I will update the migration guide after the merge.

@alexander-akait
Copy link
Member Author

We need couple test here, I will add them

@alexander-akait alexander-akait force-pushed the refactor-remove-entry-options-in-favor-manual branch from deb8b06 to 1c8757b Compare July 12, 2021 13:38
@alexander-akait alexander-akait merged commit 091ece8 into master Jul 12, 2021
@alexander-akait alexander-akait deleted the refactor-remove-entry-options-in-favor-manual branch July 12, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants