fix: rename methods #3381
Merged
fix: rename methods #3381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshumanv
requested review from
alexander-akait,
hiroppy,
knagaitsev and
snitin315
as code owners
snitin315
reviewed
Jun 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #3381 +/- ##
=======================================
Coverage 95.70% 95.71%
=======================================
Files 33 33
Lines 1304 1307 +3
Branches 384 387 +3
=======================================
+ Hits 1248 1251 +3
Misses 52 52
Partials 4 4
Continue to review full report at Codecov.
|
3 tasks
byCedric
added a commit
to expo/expo
that referenced
this pull request
Dec 16, 2023
# Why This patches SDK 49 with a fix to "support" `webpack-dev-server@v4`. # How - `sockWrite` was renamed to `sendMessage` in `webpack-dev-server@4.0.0-rc.0` ([PR](webpack/webpack-dev-server#3381), [release](webpack/webpack-dev-server@v4.0.0-beta.3...v4.0.0-rc.0#diff-b706bbadb3d2315d99678f05e1f4bfd78a4bb4a7a6c65f3e81f1386fee3c883aL111)) - Updated assertion and `broadcastMessage` in `WebpackBundlerDevServer`. # Test Plan - `$ bun create expo ./test-webpack --template blank@49 - `$ bun expo install react-native-web react-dom @expo/webpack-config` - `$ bun expo start` - Press `w` in terminal - Press `r` in terminal - This should render `No apps connected. Sending "reload" to all React Native apps failed.` (without crashing the CLI process with a `CommandError: ...`). # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
existing
Motivation / Use-Case
better methods
Breaking Changes
none
Additional Info