fix(client): use location protocol on ipv6 any (::) host #2868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v4 #2868 +/- ##
==========================================
- Coverage 92.45% 92.44% -0.02%
==========================================
Files 38 38
Lines 1246 1244 -2
Branches 326 324 -2
==========================================
- Hits 1152 1150 -2
Misses 89 89
Partials 5 5
Continue to review full report at Codecov.
|
|
@hiroppy I wan to merge and do beta release, if we will have problems, we will fix it in the next PR, but I found it is bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes.
Motivation / Use-Case
The location protocol was used on the ipv4
INADDR_ANY(0.0.0.0) host but not on the ipv6 one (::).Breaking Changes
N/A
Additional Info