BREAKING CHANGE: remove CLI default flag values for webpack-cli serve

[knagaitsev]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

Not yet

Motivation / Use-Case

We do not want default values for webpack-cli serve flags, because this makes it much easier to merge CLI flags with the user's devServer options in their webpack config

Breaking Changes

• Minor createConfig util API changes

Additional Info

[codecov]

Codecov Report

Merging #2659 into v4 will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               v4    #2659      +/-   ##
==========================================
+ Coverage   92.88%   92.89%   +0.01%     
==========================================
  Files          37       37              
  Lines        1293     1295       +2     
  Branches      344      345       +1     
==========================================
+ Hits         1201     1203       +2     
  Misses         88       88              
  Partials        4        4              

Impacted Files	Coverage Δ
client-src/default/utils/log.js	100.00% <ø> (ø)
lib/utils/createConfig.js	95.58% <100.00%> (+0.13%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86140c5...accce0f. Read the comment docs.

[alexander-akait]

Need fix CI

[knagaitsev]

I just realized that the default behavior I added in normalizeOptions was already added recently:

webpack-dev-server/lib/utils/normalizeOptions.js

Line 5 in eb9c58d

options.serveIndex =

[alexander-akait]

/cc @hiroppy

[alexander-akait]

@Loonride Looks something broken on CI

[knagaitsev]

I thought some slight refactoring on the current CLI flags (options.js) would be good to do here as well, since they are not necessary. There should be no breaking changes related to this besides slight util API changes like with createConfig. The 3 options for which I removed default CLI values are:

• host - the default of localhost is now set in createConfig
• client-logging - the default of info was already being set on the client side here:

  webpack-dev-server/client-src/default/utils/log.js

  Line 16 in 11832a0

  setLogLevel(defaultLevel);

• liveReload - the default of true was already being set in normalizeOptions, so this default is already applied for both CLI and API

[alexander-akait]

Why we have it here?

[knagaitsev]

Why we have it here?

@evilebottnawi We need it for this: webpack/webpack-cli#1649 (comment). Unless we want to add this flag on the webpack-cli side, but I think it is easiest to keep it uniform with other CLI flags

[alexander-akait]

It is already added on webpack-cli side

[knagaitsev]

It is already added on webpack-cli side

Do you know where to find it on webpack-cli side? I can't seem to find it

Edit: never mind, I think I found the PR

[alexander-akait]

webpack/webpack-cli@ad0779f

[alexander-akait]

Yes 👍

[alexander-akait]

/cc @hiroppy