chore(client): rename clientOptions to client#2655
Merged
alexander-akait merged 1 commit intowebpack:v4from Jun 24, 2020
Merged
chore(client): rename clientOptions to client#2655alexander-akait merged 1 commit intowebpack:v4from
alexander-akait merged 1 commit intowebpack:v4from
Conversation
Codecov Report
@@ Coverage Diff @@
## v4 #2655 +/- ##
==========================================
- Coverage 92.46% 92.41% -0.05%
==========================================
Files 34 34
Lines 1300 1292 -8
Branches 365 357 -8
==========================================
- Hits 1202 1194 -8
Misses 93 93
Partials 5 5
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Jun 22, 2020
Member
|
windows CI fails. |
Contributor
Author
|
@hiroppy I think it's just test instability, nothing related to the actual changes. I'm going to work on test stability improvements soon |
Member
|
Let's merge and stability test in the future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No
Motivation / Use-Case
Renaming
clientOptionstoclientBreaking Changes
Yes, renaming of option, though
clientOptionswas introduced on the v4 branch so there is no problemAdditional Info