Skip to content

ci: uncomment audit #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2020
Merged

ci: uncomment audit #2636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ jobs:
displayName: 'Install dependencies'
- script: npm run lint
displayName: 'Run lint'
# - script: npm run security
# displayName: 'Run NPM audit'
- script: npm audit --production
displayName: 'Run NPM audit'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only production? In theory dev dependencies can be vulnerable too, but at the moment we’re not auditing anything at all, so let's merge

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, but currently we can't fix yargs-parser issue. #2636 (comment)

- script: ./node_modules/.bin/commitlint-azure-pipelines
displayName: 'Run lint commit message'

Expand Down
57 changes: 45 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"lint": "npm-run-all -l -p \"lint:**\"",
"lint:type": "tsc --noEmit",
"commitlint": "commitlint --from=master",
"security": "npm audit",
"test:only": "jest --forceExit",
"test:coverage": "npm run test:only -- --coverage",
"test:watch": "npm run test:coverage --watch",
Expand Down