refactor(addEntries): make use of includes #2205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
requested review from
alexander-akait and
hiroppy
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2205 +/- ##
==========================================
- Coverage 93.91% 93.89% -0.02%
==========================================
Files 34 34
Lines 1282 1278 -4
Branches 371 363 -8
==========================================
- Hits 1204 1200 -4
Misses 71 71
Partials 7 7
Continue to review full report at Codecov.
|
alexander-akait
previously approved these changes
Aug 20, 2019
hiroppy
requested changes
Aug 20, 2019
jamesgeorge007
force-pushed
the
feat/refactor
branch
from
ff3c40f to
b45f1bf
Compare
hiroppy
approved these changes
Aug 21, 2019
hiroppy
changed the title
alexander-akait
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
refactor code to result in a much concise version.
Breaking Changes
N/A
Additional Info
N/A