-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(deps): update dependency ws to v7 #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ws seems to be supported over v8. BTW, I want to drop Node6. (because it will be End-of-Life on 30th April) @evilebottnawi What do you think? |
|
Yes i think we can do this |
|
But before i think we should fix popular bugs and popular feature requests |
eaff3d5 to
25288d4
Compare
Codecov Report
@@ Coverage Diff @@
## next #1834 +/- ##
=======================================
Coverage 92.35% 92.35%
=======================================
Files 28 28
Lines 1060 1060
Branches 322 322
=======================================
Hits 979 979
Misses 77 77
Partials 4 4Continue to review full report at Codecov.
|
5e2701e to
ad95d88
Compare
f09d853 to
7213e1f
Compare
276c35e to
79a268d
Compare
79a268d to
ba7015d
Compare
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. |
This PR contains the following updates:
^6.2.1->^7.0.0Release Notes
websockets/ws
v7.0.0Compare Source
Breaking changes
1e6999b).url.Urlinstances in theWebSocketconstructor(
692d7b4).WebSocket#{p{i,o}ng,send}()has changed when thereadyStateattribute is notOPEN(#1532)CONNECTING, an exception is thrown.CLOSINGorCLOSEDbufferedAmountattribute is increased by the length of thedataargument in bytes.
callbackfunction is called with an error.callbackfunction is not provided.Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.