Skip to content

run v2 on Travis and Appveyor #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2019
Merged

run v2 on Travis and Appveyor #1737

merged 2 commits into from
Mar 23, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Mar 23, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

Run v2 on Travis.

Breaking Changes

no

Additional Info

@hiroppy hiroppy changed the base branch from master to v2 March 23, 2019 08:10
@hiroppy hiroppy changed the title run v2 on Travis [WIP] run v2 on Travis Mar 23, 2019
@hiroppy hiroppy force-pushed the feature/modify-ci branch from 41dfc02 to 8c14159 Compare March 23, 2019 08:19
@hiroppy
Copy link
Member Author

hiroppy commented Mar 23, 2019

CI got results as expected below.
https://travis-ci.org/webpack/webpack-dev-server/jobs/510249446
https://ci.appveyor.com/project/sokra/webpack-dev-server/builds/23301872/job/5qhdg00qbsa9u3al

/Users/webpack/webpack-dev-server/lib/Server.js:545
  ).hostname;
  ^

This is already fixed by #1736 so I want to merge this pr even if CI failed.

@hiroppy hiroppy force-pushed the feature/modify-ci branch from daf2841 to 7b28d26 Compare March 23, 2019 08:50
@hiroppy hiroppy changed the title [WIP] run v2 on Travis [WIP] run v2 on Travis and Appveyor Mar 23, 2019
@hiroppy hiroppy changed the title [WIP] run v2 on Travis and Appveyor run v2 on Travis and Appveyor Mar 23, 2019
@hiroppy hiroppy force-pushed the feature/modify-ci branch from 7b28d26 to 42ea465 Compare March 23, 2019 09:08
@alexander-akait
Copy link
Member

/cc @hiroppy need rebase 👍

@hiroppy hiroppy force-pushed the feature/modify-ci branch from 42ea465 to 60574e0 Compare March 23, 2019 13:25
@hiroppy
Copy link
Member Author

hiroppy commented Mar 23, 2019

/cc @evilebottnawi rebased. PTAL

@alexander-akait alexander-akait merged commit 2a43fc7 into v2 Mar 23, 2019
@alexander-akait alexander-akait deleted the feature/modify-ci branch March 23, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants