refactor: utils #1682
refactor: utils #1682
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1682 +/- ##
==========================================
+ Coverage 79.59% 84.14% +4.55%
==========================================
Files 7 7
Lines 544 511 -33
Branches 165 155 -10
==========================================
- Hits 433 430 -3
+ Misses 84 64 -20
+ Partials 27 17 -10
Continue to review full report at Codecov.
|
alexander-akait
force-pushed
the
refactor-utils-to-lib
branch
from
0472b0c to
4cefefb
Compare
| arrow-parens, | ||
| array-bracket-spacing, | ||
| space-before-function-paren | ||
| no-console | ||
| */ |
There was a problem hiding this comment.
Remove eslint comments around stylistics rules, we use prettier 👍
| const createConfig = require('../lib/utils/createConfig'); | ||
| const getVersions = require('../lib/utils/getVersions'); | ||
| const runBonjour = require('../lib/utils/runBonjour'); | ||
| const status = require('../lib/utils/status'); |
There was a problem hiding this comment.
Move this to utils, we should testing their, let's do it in other PR
There was a problem hiding this comment.
Thank you for separating to utils 🙏
| if (!headerToCheck) headerToCheck = 'host'; | ||
| if (!headerToCheck) { | ||
| headerToCheck = 'host'; | ||
| } |
There was a problem hiding this comment.
Add { and } to all construction (better reading), we should enforce this rule in eslint, let's do it in other PR
|
No changes, only refactor |
|
/cc @hiroppy all works done, feel free to review |
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Move utils to lib for better testing ans solve future problem when
open/bonjuredoesn't work without CLIBreaking Changes
No
Additional Info
No