Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): add index #1641

Merged
merged 2 commits into from
Jan 29, 2019
Merged

docs(README): add index #1641

merged 2 commits into from
Jan 29, 2019

Conversation

bhavya9107
Copy link
Contributor

@bhavya9107 bhavya9107 commented Jan 25, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Better navigation

Breaking Changes

Additional Info

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@alexander-akait
Copy link
Member

README already very small, no need navigation, i think

@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #1641 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1641   +/-   ##
=======================================
  Coverage   74.27%   74.27%           
=======================================
  Files          10       10           
  Lines         688      688           
=======================================
  Hits          511      511           
  Misses        177      177

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 519b703...0dd1d54. Read the comment docs.

@bhavya9107
Copy link
Contributor Author

README already very small, no need navigation, i think

it makes doc better and more efficient to be referred. I think it must be there

@@ -18,6 +18,15 @@ live reloading. This should be used for **development only**.

It uses [webpack-dev-middleware][middleware-url] under the hood, which provides
fast in-memory access to the webpack assets.
## Table of Contents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline before and after header

Copy link
Contributor Author

@bhavya9107 bhavya9107 Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please reply on this

@alexander-akait alexander-akait merged commit 11c9896 into webpack:master Jan 29, 2019
@alexander-akait
Copy link
Member

Thanks!

carlosgeos pushed a commit to carlosgeos/webpack-dev-server that referenced this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants