fix(tests): update jest #785
Conversation
|
Also disables ts test in |
| expect(() => npmPackagesExists(["my-webpack-scaffold"])).toThrowError(TypeError); | ||
| }); | ||
|
|
||
| test("resolves packages when they are available on npm", done => { |
There was a problem hiding this comment.
I've removed this, probably causes a delay and hangs the CI. Useless as the file is fragile when cross-compiling ts/js
package.json
Outdated
| "@commitlint/prompt-cli": "^7.5.0", | ||
| "@commitlint/travis-cli": "^7.2.1", | ||
| "@types/jest": "^23.3.9", | ||
| "@std/esm": "^0.26.0", |
There was a problem hiding this comment.
devDep, so people can complain all they want
|
Green tests, golden. @webpack/cli-team I'm merging this as a temp fix so we don't get bugged with the automation complaining about the tests failing. Tests are likely to be fixed at the next branch when we're rolling out the new interface so we can discuss at tuesday if it's worth making an effort fixing the remaining tests. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Neat ✨✅ |
3 participants
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
Aye ish
If relevant, did you update the documentation?
N/A
Summary
Updates jest to make ci's pass. When updating Babel broke so we updated babel as well. This made the tests and snapshots take color ansi into stdin/stdout, so I've refactored some stuff to make tests assert for contains and not a regex, as it would fail when color codes comes in the way.
es6 test is using our api for hooking up a config at runtime rather than just bundling a file. With no real test case.
Does this PR introduce a breaking change?
No
Other information
:)