refactor!: minimum supported webpack version is 5.82.0
#4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
changed the title
5.82.0
snitin315
commented
Oct 23, 2024
| @@ -1043,20 +1043,6 @@ class WebpackCLI implements IWebpackCLI { | |||
| description: "Stop webpack-cli process with non-zero exit code on warnings from webpack.", | |||
| helpLevel: "minimum", | |||
| }, | |||
| // TODO remove this in the next major release, because not all webpack versions have this flag in CLI options | |||
| { | |||
| name: "extends", | |||
There was a problem hiding this comment.
This will come from webpack schema since https://github.com/webpack/webpack/releases/tag/v5.82.0
snitin315
force-pushed
the
udpate-commander
branch
from
048b836 to
e725176
Compare
alexander-akait
approved these changes
Oct 23, 2024
|
Looks like we need alias |
anshumanv
approved these changes
Oct 23, 2024
alexander-akait
approved these changes
Oct 23, 2024
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @alexander-akait Please review the new changes. |
snitin315
added a commit
that referenced
this pull request
Dec 17, 2024
alexander-akait
pushed a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
minimum supported webpack version is 5.82.0
Does this PR introduce a breaking change?
Yes
Other information
No