Refactor bin directory #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenstensberg
approved these changes
Feb 9, 2018
ematipico
reviewed
Feb 12, 2018
bin/config-yargs.js
Outdated
| @@ -1,11 +1,11 @@ | |||
| var CONFIG_GROUP = "Config options:"; | |||
There was a problem hiding this comment.
I guess also these can be consts?
There was a problem hiding this comment.
wow how did they get through 👍
ematipico
approved these changes
Feb 12, 2018
webpack-bot
added
PR: reviewed-approved
PR: CI-not-ok
and removed
PR: review-outdated
PR: CI-ok
labels
|
The failure doesnt look valid :/ |
|
Kicked a new build. Probably it's a random failure |
EugeneHlushko
force-pushed
the
es6-refactor-bin
branch
from
78cbb8a to
aab2a71
Compare
|
@EugeneHlushko Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
|
rebased onto master just in case |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
approved these changes
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor bin directory to be aligned with code style according to node version support.
Did you add tests for your changes?
it is not necessary
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
no
Other information