Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(help): display error message if no option provided on startup #254

Closed
wants to merge 76 commits into from
Closed

fix(help): display error message if no option provided on startup #254

Changes from 1 commit
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
5a040ba
bugfix - display error message if no option provided on startup
sumit-gupta91 Jan 26, 2018
d43ab9f
added test for no-options
sumit-gupta91 Feb 1, 2018
37cb6d8
Merge remote-tracking branch 'upstream/master' into bugfix/error-msg-…
sumit-gupta91 Feb 26, 2018
580395a
refactor- intercept webpack error and transform to show no options error
sumit-gupta91 Mar 4, 2018
ec6cc38
chore(monorepo): move to lerna
sendilkumarn Mar 18, 2018
bdafce0
chore(monorepo): use commands as normal instead of package
sendilkumarn Mar 18, 2018
3dd244b
fix(revert): packagejson
sendilkumarn Mar 18, 2018
059d6f9
chore(monorepo): prune files and update eslint rules
sendilkumarn Mar 18, 2018
8ef1804
chore(monorepo): fix the no-missing-require error
sendilkumarn Mar 18, 2018
a1d5406
chore(monorepo): fix typo
sendilkumarn Mar 18, 2018
a6a2715
chore(monorepo): fix typo
sendilkumarn Mar 18, 2018
e9bc6eb
Merge branch 'master' into lerna-workspace
sendilkumarn Mar 20, 2018
64cfef7
chore(monorepo): prune package json
sendilkumarn Mar 20, 2018
2738a1e
Merge branch 'next' into lerna-workspace
sendilkumarn Apr 4, 2018
d4c7c5d
chore(monorepo): merge package lock json
sendilkumarn Apr 4, 2018
ff6c371
chore(monorepo): updated package.json
sendilkumarn Apr 4, 2018
3c822cf
chore(monorepo): fix plugin package.json
sendilkumarn Apr 4, 2018
bdf7e5a
Merge pull request #353 from sendilkumarn/lerna-workspace
sendilkumarn Apr 15, 2018
2d58452
Merge remote-tracking branch 'upstream/master' into bugfix/error-msg-…
sumit-gupta91 May 8, 2018
a01a0c5
fixed test cases
sumit-gupta91 May 8, 2018
8a02f35
remove unwanted console
sumit-gupta91 May 8, 2018
fa452a0
chore(cli): move to lerna and scoped packages (#434)
evenstensberg May 14, 2018
b1a8398
chore(rebase): merge master branch
evenstensberg May 14, 2018
1db677e
chore(linting): resolve linter errors
evenstensberg May 14, 2018
a76c46f
chore(linting): fix linting errors
evenstensberg May 14, 2018
8f6f1db
chore(linting): resolve linting
evenstensberg May 14, 2018
80c9e9a
chore(linting): resolve linting
evenstensberg May 14, 2018
b2a7470
chore(scaffold): move addons to scaffold
evenstensberg May 14, 2018
df8287d
chore(scaffold): fix linting errors
evenstensberg May 14, 2018
f8a71c0
cli(prompt): initial comment for prompt file
evenstensberg May 14, 2018
5f357c9
cli(prompt): wip
evenstensberg May 14, 2018
74fb759
fix(monorepo): fix lint errors
sendilkumarn May 15, 2018
0fcc5b3
fix(monorepo): fix cross spawn versions
sendilkumarn May 15, 2018
ca8f5c1
fix(monorepo): update lock files
sendilkumarn May 15, 2018
2b3035c
fix(monorepo): fix versions in pacakges
sendilkumarn May 15, 2018
b02070d
chore(rebase): refactor stuff
evenstensberg May 17, 2018
b2c2bbd
cli(pkgs): re-add entries
evenstensberg May 17, 2018
ab38a3a
chore(v): revise pkg
evenstensberg May 17, 2018
faae7aa
v0.0.1
evenstensberg May 17, 2018
c36f3e8
chore(v): revise some deps
evenstensberg May 17, 2018
91be3fd
v0.0.2
evenstensberg May 17, 2018
b51e66d
v0.0.3
evenstensberg May 17, 2018
3ed29c6
chore(v): back to v1
evenstensberg May 17, 2018
6489b10
v0.0.2
evenstensberg May 17, 2018
01cef3f
v0.0.3
evenstensberg May 17, 2018
e29a173
v0.0.4
evenstensberg May 17, 2018
58a437d
chore(deps): update deps
evenstensberg May 17, 2018
bccc56e
chore(prompt): revise prompt cmd
evenstensberg May 17, 2018
062fa28
v0.0.5
evenstensberg May 17, 2018
7fca948
cli(path): resolve better
evenstensberg May 17, 2018
f544578
v0.0.6
evenstensberg May 17, 2018
ebe5c6b
chore(v.6): update init
evenstensberg May 17, 2018
3a82b7d
chore(pkg): v.6 on next
evenstensberg May 17, 2018
17c2c88
chore(monorepo): add bootstrap to run
sendilkumarn May 17, 2018
42468d3
chore(monorepo): fix appveyor build
sendilkumarn May 17, 2018
a08b899
chore(monorepo): fix appveyor build
sendilkumarn May 18, 2018
ae55183
chore(monorepo): add eslint-plugin-prettier
sendilkumarn May 18, 2018
206749b
chore(monorepo): fix appveyor build
sendilkumarn May 17, 2018
7de58ea
chore(monorepo): fix versions and use clean bootstrap
sendilkumarn May 18, 2018
7c0e245
chore(monorepo): add rimraf globally
sendilkumarn May 18, 2018
2be0bce
Merge branch 'next' of https://github.com/webpack/webpack-cli into next
evenstensberg May 19, 2018
8c58d24
chore(monorepo): fix windows build
sendilkumarn May 19, 2018
e87fd7d
cli(color): don't use color on non-tty (#452)
evenstensberg May 20, 2018
0989b1d
Added yarn lock file to gitignore (#455)
nveenjain May 20, 2018
77cbf01
fix(254) - addressed PR comments
sumit-gupta91 May 21, 2018
76416ff
fix(254) - added requested changes at right place
sumit-gupta91 May 21, 2018
78b48a6
chore(next): dev version bump
evenstensberg May 21, 2018
0310fd3
chore(monorepo): fix windows build
sendilkumarn May 21, 2018
217670f
cli(symlinks): Fix paths (#453)
evenstensberg May 21, 2018
8e48e37
cli(init): Better defaults (#451)
evenstensberg May 22, 2018
6be1af0
fix(254) - exit after error
sumit-gupta91 May 22, 2018
92816e1
fix(vulnerabilities): vulnerabilities patch for v3 (#460)
dhruvdutt May 24, 2018
422191c
Merge remote-tracking branch 'upstream/next' into bugfix/error-msg-fo…
sumit-gupta91 May 26, 2018
b305327
merge from master
sumit-gupta91 May 26, 2018
610ec1e
Merge remote-tracking branch 'upstream/master' into bugfix/error-msg-…
sumit-gupta91 May 26, 2018
eec7a3c
merge from master
sumit-gupta91 May 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(254) - addressed PR comments
  • Loading branch information
@sumit-gupta91
sumit-gupta91 committed May 21, 2018
commit 77cbf0164879203a3b73c2331e4600d15361666d
2 changes: 1 addition & 1 deletion bin/webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ For more information, see https://webpack.js.org/api/cli/.`);
lastHash = stats.hash;
if (stats.compilation && stats.compilation.errors.length !== 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&& outputOptions.entry === undefined

Copy link
Member Author

@sumit-gupta91 sumit-gupta91 May 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ev1stensberg I would like to get some context on this comment Left a comment. Also, @sokra do you handle default setting in webpack internals? I think the CLI should do that. Sean did a PR but can't find the changes did there.. What I can make of it is this if no option is provided then webpack-cli should throw an error and webpack should not be called. Is my understanding correct ?

const errors = stats.compilation.errors;
if (errors[0].name === "EntryModuleNotFoundError") {
if (errors[0].name === "EntryModuleNotFoundError" && outputOptions.entry === undefined) {
stdout.write(
"\n" + logSymbols.error + chalk.blue(" ERROR ") + "Insufficient number of arguments provided " +
"\n" + logSymbols.info + chalk.blue(" INFO ") + "Alternatively, run `webpack(-cli) --help` for usage info." +
Expand Down