-
-
Notifications
You must be signed in to change notification settings - Fork 635
feat: add mjs support #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mjs support #2172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mjs test failing
Yep, WIP on this |
Found the problem - |
Confirm this. Will update the PR accordingly as native import works too without |
@rishabh3112 don't touch this PR, I am working on it |
I am already done with native import + added env variable to github actions locally 😞 |
What do you mean? |
Tests should be fine now, I don't know how to better fix bug in |
I was done with required changes at that point of time with a different approach. Yours is better so never mind 🙂
Yup seems way to go. |
Codecov Report
@@ Coverage Diff @@
## master #2172 +/- ##
==========================================
- Coverage 68.35% 68.27% -0.09%
==========================================
Files 72 72
Lines 2345 2358 +13
Branches 518 520 +2
==========================================
+ Hits 1603 1610 +7
- Misses 742 748 +6
Continue to review full report at Codecov.
|
2db2eeb
to
4125080
Compare
Very weird, it works locally, but throw an error on CI, even for node@14, tests in webpack-cli is pain |
Seems to be passing everywhere (few are still running) now. Will look into it if this run fails. |
Bug on |
Anyway es configuration is not supported fully due |
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
Yup
If relevant, did you update the documentation?
No
Summary
New PR that supersedes #1786
Does this PR introduce a breaking change?
No
Other information
Fresh start