feat: add WEBPACK_SERVE environment variable #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
Nov 4, 2020
anshumanv
reviewed
Nov 4, 2020
snitin315
approved these changes
Nov 4, 2020
anshumanv
approved these changes
Nov 4, 2020
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add WEBPACK_SERVE variable in environment and in main process if
webpack serveis used.Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
Fixes #1973
Does this PR introduce a breaking change?
Yes,
WEBPACK_SERVEvariable which was earlierWEBPACK_DEV_SERVERwhen dev server was not integrated into CLI.WEBPACK_SERVEis now accessable only throughenvargument supplied to webpack configuration of typefunction.Other information
/cc @evilebottnawi