Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: config group to pure function and move away from group design #1811

Merged
merged 9 commits into from
Sep 21, 2020
+195 −196
Merged

refactor: config group to pure function and move away from group design #1811

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8f6d624
chore: remove default value from config/entry flag
anshumanv Sep 19, 2020
a539d1d
chore: remove default value from config/entry flag
anshumanv Sep 19, 2020
41963fa
feat: refactor config group to pure function
anshumanv Sep 19, 2020
88873d8
chore: fix tests
anshumanv Sep 19, 2020
339f3c2
chore: fix tests
anshumanv Sep 19, 2020
a1bf24d
chore: fix typo
anshumanv Sep 20, 2020
4677337
Merge branch 'next' into rm/default-config
evenstensberg Sep 21, 2020
cac8865
Merge branch 'next' into rm/default-config
jamesgeorge007 Sep 21, 2020
af29c55
Merge branch 'next' into rm/default-config
anshumanv Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix typo
  • Loading branch information
@anshumanv
anshumanv committed Sep 20, 2020
commit a1bf24d218270d0b9d71b7b1047853fa661dca7e
2 changes: 1 addition & 1 deletion packages/webpack-cli/lib/groups/ConfigGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ let opts = {
options: {},
};

// Return a list of default configs in various forrmats
// Return a list of default configs in various formats
const getDefaultConfigFiles = () => {
return DEFAULT_CONFIG_LOC.map((filename) => {
// Since .cjs is not available on interpret side add it manually to default config extension list
Expand Down