Conversation
|
I think it makes sense to add multiple config support using flags first. |
|
https://webpack.js.org/configuration/configuration-types/#exporting-multiple-configurations |
snitin315
force-pushed
the
feat/config-name
branch
from
615a477 to
7aedac7
Compare
| const newOptions = configOptions(formattedEnv, argv); | ||
| // When config function returns a promise, resolve it, if not it's resolved by default | ||
| newOptionsObject['options'] = await Promise.resolve(newOptions); | ||
| } else if (Array.isArray(configOptions) && this.args.configName) { |
There was a problem hiding this comment.
Add a comment when this block is executed, can give example, looks good otherwise
snitin315
force-pushed
the
feat/config-name
branch
from
7aedac7 to
a41941e
Compare
|
This |
|
@snitin315 maybe we should update |
I think it's setup externally, not defined in the workflow file. @evenstensberg do you know how it's setup? |
|
It seems we're relying on commitlint-bot which is not maintained anymore, it is advised to use semantic-pull-requests instead. |
8 participants
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Addition of
--config-nameflag.Does this PR introduce a breaking change?
No
Other information
Fixes #1657