Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack-cli): allow multiple entry files #1619

Merged
merged 10 commits into from
Jun 17, 2020
Merged

feat(webpack-cli): allow multiple entry files #1619

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1b74376
feat(webpack-cli): allow multiple entries
snitin315 Jun 7, 2020
9faf38c
feat: allow multiple entry flags
snitin315 Jun 9, 2020
a78e5c9
fix: if else condition
snitin315 Jun 9, 2020
177e6f1
tests: add test for mulitple entry flags
snitin315 Jun 9, 2020
624549a
tests: update arg-parser tests
snitin315 Jun 9, 2020
ec338bf
docs: update entry docs
snitin315 Jun 9, 2020
5a74566
chore: rm logs
snitin315 Jun 9, 2020
255828f
fix: ci
snitin315 Jun 9, 2020
ba0a71b
Merge branch 'next' into feat/multi-entry
snitin315 Jun 16, 2020
3af646b
Merge branch 'next' into feat/multi-entry
anshumanv Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests: update arg-parser tests
  • Loading branch information
@snitin315
snitin315 committed Jun 9, 2020
commit 624549af8c439e72e5772748850829a72a7eff1e
19 changes: 18 additions & 1 deletion packages/webpack-cli/__tests__/arg-parser.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@ const basicOptions = [
},
description: 'custom type flag',
},
{
name: 'multi-flag',
usage: '--multi-flag <value>',
type: String,
multiple: true,
description: 'multi flag',
},
];

const helpAndVersionOptions = basicOptions.slice(0);
Expand Down Expand Up @@ -163,6 +170,16 @@ describe('arg-parser', () => {
expect(warnMock.mock.calls.length).toEqual(0);
});

it('handles multiple same args', () => {
const res = argParser(basicOptions, ['--multi-flag', 'a.js', '--multi-flag', 'b.js'], true);
expect(res.unknownArgs.length).toEqual(0);
expect(res.opts).toEqual({
multiFlag: ['a.js', 'b.js'],
stringFlagWithDefault: 'default-value',
});
expect(warnMock.mock.calls.length).toEqual(0);
});

it('handles additional node args from argv', () => {
const res = argParser(basicOptions, ['node', 'index.js', '--bool-flag', '--string-flag', 'val'], false);
expect(res.unknownArgs.length).toEqual(0);
Expand Down Expand Up @@ -210,7 +227,7 @@ describe('arg-parser', () => {
it('parses webpack args', () => {
const res = argParser(core, ['--entry', 'test.js', '--hot', '-o', './dist/'], true);
expect(res.unknownArgs.length).toEqual(0);
expect(res.opts.entry).toEqual('test.js');
expect(res.opts.entry).toEqual(['test.js']);
expect(res.opts.hot).toBeTruthy();
expect(res.opts.output).toEqual('./dist/');
expect(warnMock.mock.calls.length).toEqual(0);
Expand Down