Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack-cli): allow multiple entry files #1454

Closed
wants to merge 1 commit into from

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Apr 13, 2020

What kind of change does this PR introduce?
Feature

Did you add tests for your changes?

Yes.

If relevant, did you update the documentation?

Yes

Summary

Now multiple entry files are possible. --entry ./src/a.js ./src/b.js or --entry ./src/a.js --entry ./src/b.js

entry2

Does this PR introduce a breaking change?

Maybe

Other information

Refers #717

@snitin315 snitin315 force-pushed the feat/entry branch 10 times, most recently from c0ee8d9 to 1bfab12 Compare April 13, 2020 10:27
Signed-off-by: Nitin Kumar <snitin315@gmail.com>
@snitin315 snitin315 marked this pull request as ready for review April 13, 2020 10:47
@snitin315 snitin315 requested a review from a team as a code owner April 13, 2020 10:47
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be implemented after #1347

Anyway thanks for work, looks @rishabh3112 has problems with that PR, will be great if you help

@snitin315
Copy link
Member Author

sure, happy to help 😀

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need rebase

@snitin315
Copy link
Member Author

The code changed meanwhile a will open a new PR soon.

@snitin315
Copy link
Member Author

@anshumanv should we add this feature first or it should be done after args from the core? What do you think?

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@alexander-akait
Copy link
Member

/cc @snitin315 Can you fix conflicts?

@snitin315
Copy link
Member Author

Some extra changes to be done with commander.js. I will update PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants