-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webpack-cli): allow multiple entry files #1454
Conversation
c0ee8d9
to
1bfab12
Compare
Signed-off-by: Nitin Kumar <snitin315@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be implemented after #1347
Anyway thanks for work, looks @rishabh3112 has problems with that PR, will be great if you help
sure, happy to help 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need rebase
The code changed meanwhile a will open a new PR soon. |
@anshumanv should we add this feature first or it should be done after args from the core? What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
/cc @snitin315 Can you fix conflicts? |
Some extra changes to be done with |
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
Yes.
If relevant, did you update the documentation?
Yes
Summary
Now multiple entry files are possible.
--entry ./src/a.js ./src/b.js
or--entry ./src/a.js --entry ./src/b.js
Does this PR introduce a breaking change?
Maybe
Other information
Refers #717