Skip to content

Conversation

@ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza commented Dec 2, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Resolve #187
Resolve #190

Breaking Changes

no

Additional Info

Thanks @vankop for starting PR #190

@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #199   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         106    112    +6     
  Branches       20     24    +4     
=====================================
+ Hits          106    112    +6
Impacted Files Coverage Δ
src/LintDirtyModulesPlugin.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b5a39...d91ca3d. Read the comment docs.

@vankop
Copy link
Member

vankop commented Dec 2, 2019

@ricardogobbosouza Sorry, I forgot about it =( Thanks for making fix

@ricardogobbosouza ricardogobbosouza merged commit 3d9e544 into master Dec 4, 2019
@ricardogobbosouza ricardogobbosouza deleted the support-webpack-5 branch December 4, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crashes when using lintDirtyModulesOnly and webpack 5.beta0

4 participants