-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript Support: Don't force consumers to enable esModuleInterop in tsconfig #110
Comments
Feel free to send a PR |
ozyman42
added a commit
to ozyman42/schema-utils
that referenced
this issue
Aug 27, 2020
6 tasks
sent |
ozyman42
added a commit
to ozyman42/schema-utils
that referenced
this issue
Aug 29, 2020
alexander-akait
pushed a commit
that referenced
this issue
Aug 31, 2020
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Because of this line it means that any project which consumes
schema-utils
either as a direct or transitive dependency must use theesModuleInterop
tsconfig.json compilerOptions setting in order to compile their typescript.Ideally we should not be forcing typescript users to add this setting if they don't want it. It also isnt necessary since in
Here's a demo:
git clone https://github.com/AlexLeung/webpack-schema-utils-ajv-typescript-error-demo
npm install
npm start
You will see the following output, including a tsc error
to
npm start
again and now the compilation succeeds.The change described in step 4 is fine because we are only exporting types from the ajv package.
I'll submit a PR for this shortly.
The text was updated successfully, but these errors were encountered: