-
-
Notifications
You must be signed in to change notification settings - Fork 166
Fix reduce memory usage #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
493bccc
fix: reduce memory usage in parallel mode
alexander-akait 795a439
fix: reduce memory usage in parallel mode
alexander-akait caac36d
fix: reduce memory usage in parallel mode
alexander-akait 10ad03b
fix: reduce memory usage in parallel mode
alexander-akait 94dd633
fix: reduce memory usage in parallel mode
alexander-akait 6280fdb
fix: reduce memory usage in parallel mode
alexander-akait 83b7b21
fix: reduce memory usage in parallel mode
alexander-akait 191d6fc
fix: reduce memory usage in parallel mode
alexander-akait 0fe9d2f
fix: reduce memory usage in parallel mode
alexander-akait 7a3499f
fix: reduce memory usage in parallel mode
alexander-akait fcc3d5b
fix: reduce memory usage in parallel mode
alexander-akait acc6c04
fix: reduce memory usage in parallel mode
alexander-akait 2680f94
fix: reduce memory usage in parallel mode
alexander-akait File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think
plimitmakes any guarantee about the order of execution of the enqueued functions. I think this means thatenqueue(task)can be called in any order and thereforetask.callback(taskResult)can be, too.This seems like it has the potential to introduce non-determinism whenever parallelism is enabled. That is, if I run my webpack build twice, I expect it to produce the same outputs. This change seems to break that guarantee whenever
extractCommentsis on since comment extraction depends on processing the results in a particular order.It is important that this plugin is deterministic because nondeterministic builds needlessly invalidate long-term caches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need sort properties of
allExtractedCommentshere https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/src/index.js#L509There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix it in near future
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, not sure the problem exists:
We sort comments inside each file, so output is deterministic
Webpack sort assets by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think you're right. Since comments are sorted and then de-duped after being collected in
allExtractedComments, I think the output is deterministic.