refactor(loader): v1.0.0 #157

michael-ciniawsky · 2017-12-10T06:48:42Z

`Noteable Changes`

`Features`

`url` (`options.url`)

file.html

<body>
 <img src="path/to/file.png">
</body>

module.js

import HTML__URL__0 from 'path/to/file.png';

export default `<body>
  <img src="${HTML__URL__0}">
</body>
`

`import` (`options.import`)

file.html

<body>
  <import src="path/to/import.html">
</body>

module.js

import HTML__IMPORT__0 from 'path/to/import.html';

export default `<body>
  ${HTML__IMPORT__0}
</body>
`

`template` (`options.template`)

file.html

<body>
  <h1>${ _.hello }</h1>
</body>

entry.js

import template from './file.html';

const html = template({ hello: 'Hello World' });

document.body.innerHTML = `${html}`;

`minimize` (`options.minimize`)

Using htmlnano

`BREAKING CHANGES`

`root` (`options.root`)

Removed

`attrs` (`options.attrs`)

Removed (will be handled by the url plugin)

`interpolate` (`options.interpolate`)

Removed in favor of options.template

`exportAsDefault && exportAsEs6Default` (`options.exportAsDefault|options.exportAsEs6Default`)

Removed in favor of just exporting an ES2015 Module :)

`Issues`

closes all Issues prior to html-loader <= v1.0.0

`TODO`

port changes from src/lib/plugins/url to posthtml-include (PR #?, Issue [v1.0.0-alpha (Feature)] support custom URL filters (options.import|options.url) #158, Issue [v1.0.0-alpha (Feature)] support explicit { tag: 'attr' } patterns for URL resolving (options.url) #159)
- add plugin option to filter urls {Regex|Function}
port changes from src/lib/plugins/import to posthtml-url (PR #?, Issue [v1.0.0-alpha (Feature)] support custom URL filters (options.import|options.url) #158)
- add plugin option to filter urls {Regex|Function}

`Status`

Name	Status
Default	✅
HTML URLs	✅
HMTL Imports	✅
HMTL Templates	✅
HTML Minification	✅

`Blocked by`

~~posthtml/posthtml #236~~ (Merged && Released 🎉)

alexander-akait

Looks good!

joshwiens · 2017-12-14T09:32:57Z

@michael-ciniawsky - Don't worry about splitting things in this PR.

Just edit the initial comment in #155 and add the appropriate Breaking Changes & we can handle the release notes portion there.

joshwiens

This is fine for now. We will all have to take another look at everything in next with any other v4 related updates

michael-ciniawsky · 2017-12-14T09:44:16Z

I rebase the commit into CHANGELOG suiteable commits, revisit this one more time and land it on next during the day then ? So folks can test it out and I add the filters for options.url && options.import in follow up PR's ? Especially the current default url filter is a bit too aggressive :D

@d3viant0ne What is required to enable to CI e.g ok/sufficient to change the travis.yml to remove the master only stuff there (making a note to add it back, once this may land on master of course 🙃)? Or how should we proceed at best ?

joshwiens · 2017-12-14T09:47:02Z

https://github.com/webpack-contrib/html-loader/blob/acda6f9026df5d9b341728cd543b5ed43cacfc4e/.travis.yml#L6

Just need to add - next to the branches list

Given next is used by Webpack already & something we are going to adopt, it should be in the branches list.

That list is actually necessary, it prevents Travis from running twice on pull requests.

joshwiens · 2017-12-14T09:49:36Z

@michael-ciniawsky - We can land it now if you want. Once we are reasonably sure about next after this lands, we can throw out an initial .alpha-0 build to get people beating on it.

michael-ciniawsky · 2017-12-14T10:06:11Z

I have one cricital bug fix locally and e2e tests (JSDOM), just a few minutes (~30) 😛 for final self review and to split the commits.

joshwiens · 2017-12-14T21:07:26Z

@michael-ciniawsky - When you are satisfied with this, just merge it into next. I'll apply defaults 2.0 to that branch once it's finished & we can start getting alpha builds out.

michael-ciniawsky · 2017-12-15T10:00:59Z

@d3viant0ne I just saw your comment I can leave the defaults v1.6.0...2.0.0 out of this PR if you want I test it out for myself in e.g style-loader, css-loader instead. Should I leave it here ?

joshwiens · 2017-12-15T11:04:23Z

We can do it as a separate PR or you can update in this one. I suppose for the sake of keeping the commits in next as simple as possible for review, it may be easier to do the defaults upgrade as a separate pull request given the amount of change already in this one.

michael-ciniawsky · 2017-12-15T11:07:54Z

kk I will leave it and open an issue alongside with the others I open for other contribs and as remaining TODO list, finally spit the commit here, land this PR in the next few moments (one final CI run) and then on to the CSS related stuff... 😛

codecov · 2017-12-15T11:34:03Z

Codecov Report

❗ No coverage uploaded for pull request base (next@acda6f9). Click here to learn what that means.
The diff coverage is 98.92%.

@@           Coverage Diff           @@
##             next     #157   +/-   ##
=======================================
  Coverage        ?   97.89%           
=======================================
  Files           ?        5           
  Lines           ?       95           
  Branches        ?       32           
=======================================
  Hits            ?       93           
  Misses          ?        2           
  Partials        ?        0

Impacted Files	Coverage Δ
src/lib/plugins/import.js	`100% <100%> (ø)`
src/lib/Error.js	`100% <100%> (ø)`
src/lib/plugins/url.js	`100% <100%> (ø)`
src/index.js	`97.5% <97.43%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acda6f9...fea918f. Read the comment docs.

…support (`options.import`)

…url`)

…(`CommonsChunkPlugin`)

michael-ciniawsky · 2017-12-15T12:54:01Z

Circle CI is expected to fail for this PR due to the missing setup (webpack-defaults@next)

The webpack Canary failure of the e2e tests is related to file-loader #234

michael-ciniawsky added priority: 3 (required) pr_action: Discuss semver: Major status: Needs triage type: Refactor labels Dec 10, 2017

michael-ciniawsky added this to the 1.0.0 milestone Dec 10, 2017

michael-ciniawsky added the branch: Next label Dec 10, 2017

michael-ciniawsky mentioned this pull request Dec 11, 2017

feat(index): add support for messages (result.messages) posthtml/posthtml#236

Merged

michael-ciniawsky requested review from alexander-akait and joshwiens December 11, 2017 03:45

michael-ciniawsky force-pushed the new branch 3 times, most recently from a9627b7 to fff191e Compare December 12, 2017 09:57

webpack deleted a comment from jsf-clabot Dec 12, 2017

michael-ciniawsky force-pushed the new branch 2 times, most recently from a5f9941 to 328edf1 Compare December 13, 2017 01:40

michael-ciniawsky changed the title ~~[WIP] refactor(loader): v1.0.0~~ refactor(loader): v1.0.0 Dec 13, 2017

alexander-akait approved these changes Dec 13, 2017

View reviewed changes

joshwiens approved these changes Dec 14, 2017

View reviewed changes

michael-ciniawsky force-pushed the new branch from 328edf1 to a67a057 Compare December 14, 2017 18:17

michael-ciniawsky force-pushed the new branch from a67a057 to b53ad35 Compare December 15, 2017 11:34

michael-ciniawsky added 7 commits December 15, 2017 12:55

build(defaults): apply webpack-defaults

a6c12be

docs(README): v1.0.0-alpha

c0af67d

test: standardize

54ea2ea

feat: add options validation (schema-utils)

c3689ac

feat: use posthtml for HTML processing

c5f14ff

feat(plugins/import): add <import src="./file.html> (HTML Imports) …

6a0fc34

…support (`options.import`)

feat(plugins/url): add asset resolving (HTML URLs) support (`options.…

2db0f2d

…url`)

michael-ciniawsky force-pushed the new branch from b53ad35 to 2db0f2d Compare December 15, 2017 12:08

test(helpers/compiler): use options.names instead of option.name …

fea918f

…(`CommonsChunkPlugin`)

michael-ciniawsky merged commit 94b21d4 into next Dec 15, 2017

michael-ciniawsky deleted the new branch December 15, 2017 12:55

michael-ciniawsky added status: Approved and removed branch: Next priority: 3 (required) pr_action: Discuss status: Needs triage labels Dec 15, 2017

Uh oh!

refactor(loader): v1.0.0 #157

refactor(loader): v1.0.0 #157

Uh oh!

Conversation

michael-ciniawsky commented Dec 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Noteable Changes

Features

url (options.url)

import (options.import)

template (options.template)

minimize (options.minimize)

BREAKING CHANGES

root (options.root)

attrs (options.attrs)

interpolate (options.interpolate)

exportAsDefault && exportAsEs6Default (options.exportAsDefault|options.exportAsEs6Default)

Issues

TODO

Status

Blocked by

Uh oh!

alexander-akait left a comment

Choose a reason for hiding this comment

Uh oh!

joshwiens commented Dec 14, 2017

Uh oh!

joshwiens left a comment

Choose a reason for hiding this comment

Uh oh!

michael-ciniawsky commented Dec 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshwiens commented Dec 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshwiens commented Dec 14, 2017

Uh oh!

michael-ciniawsky commented Dec 14, 2017

Uh oh!

joshwiens commented Dec 14, 2017

Uh oh!

michael-ciniawsky commented Dec 15, 2017

Uh oh!

joshwiens commented Dec 15, 2017

Uh oh!

michael-ciniawsky commented Dec 15, 2017

Uh oh!

codecov bot commented Dec 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

michael-ciniawsky commented Dec 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

michael-ciniawsky commented Dec 10, 2017 •

edited

Loading

`Noteable Changes`

`Features`

`url` (`options.url`)

`import` (`options.import`)

`template` (`options.template`)

`minimize` (`options.minimize`)

`BREAKING CHANGES`

`root` (`options.root`)

`attrs` (`options.attrs`)

`interpolate` (`options.interpolate`)

`exportAsDefault && exportAsEs6Default` (`options.exportAsDefault|options.exportAsEs6Default`)

`Issues`

`TODO`

`Status`

`Blocked by`

michael-ciniawsky commented Dec 14, 2017 •

edited

Loading

joshwiens commented Dec 14, 2017 •

edited

Loading

codecov bot commented Dec 15, 2017 •

edited

Loading

michael-ciniawsky commented Dec 15, 2017 •

edited

Loading