Skip to content

[2.x] feat: removed cjs wrapper#154

Merged
ricardogobbosouza merged 3 commits into
2.xfrom
2.x-feat-remove-cjs-wrapper
Jun 18, 2022
Merged

[2.x] feat: removed cjs wrapper#154
ricardogobbosouza merged 3 commits into
2.xfrom
2.x-feat-remove-cjs-wrapper

Conversation

@ricardogobbosouza

@ricardogobbosouza ricardogobbosouza commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

removed cjs wrapper and generated types in commonjs format (export = and namespaces used in types), now you can directly use exported types

Breaking Changes

Potentially yes, but now we use invalid format our types

Additional Info

No

@ricardogobbosouza ricardogobbosouza changed the title feat: removed cjs wrapper [2.x] feat: removed cjs wrapper Apr 29, 2022
@codecov

codecov Bot commented Apr 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #154 (b90ef37) into 2.x (3ac6f4e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               2.x      #154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         7    -1     
  Lines          252       275   +23     
  Branches        73        75    +2     
=========================================
+ Hits           252       275   +23     
Impacted Files Coverage Δ
src/ESLintError.js 100.00% <100.00%> (ø)
src/getESLint.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)
src/linter.js 100.00% <100.00%> (ø)
src/options.js 100.00% <100.00%> (ø)
src/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac6f4e...b90ef37. Read the comment docs.

@ricardogobbosouza
ricardogobbosouza merged commit 8abd6e4 into 2.x Jun 18, 2022
@ricardogobbosouza
ricardogobbosouza deleted the 2.x-feat-remove-cjs-wrapper branch June 18, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants