Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

fix: Modules shouldn't be passed to sort #568

Merged
merged 1 commit into from
Jul 10, 2017
Merged

fix: Modules shouldn't be passed to sort #568

merged 1 commit into from
Jul 10, 2017

Conversation

@joshwiens
Copy link
Member

@joshwiens joshwiens commented Jul 10, 2017 •
edited
Loading

  • module was incorrectly being passed to the sort function with throws a type error in certain circumstances.

Fixes #565
Fixes #554

@joshwiens joshwiens merged commit 113cabb into feature/webpack3 Jul 10, 2017
@joshwiens joshwiens deleted the d3viant0ne-FixTypeError branch July 10, 2017 01:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

2 more reviewers

@hulkish hulkish hulkish approved these changes

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr_action: Review priority: 3 (required) semver: Patch severity: 2 (regression) type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshwiens @hulkish @michael-ciniawsky