Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

fix: use path.relative to determine if resource path is relative to cwd #336

Closed
wants to merge 1 commit into from

Conversation

githoniel
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

this should fix #335

Breaking Changes

No

Additional Info

@jsf-clabot
Copy link

jsf-clabot commented Jul 24, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #336 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   94.79%   94.84%   +0.05%     
==========================================
  Files           8        8              
  Lines         192      194       +2     
  Branches       51       52       +1     
==========================================
+ Hits          182      184       +2     
  Misses          7        7              
  Partials        3        3              
Impacted Files Coverage Δ
src/Linter.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed54da5...01757c1. Read the comment docs.

@githoniel
Copy link
Author

githoniel commented Sep 10, 2020

close due to no response for a long time while in my timeline everyday

@githoniel githoniel closed this Sep 10, 2020
@alexander-akait
Copy link
Member

@githoniel eslint-loader will be deprecated in near future please use allExtractedComments

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relative path is wrong when use eslint-loader in monorepo
3 participants