This repository has been archived by the owner on Sep 28, 2020. It is now read-only.
chore: update dependency module object-hash to version 2.0.1 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 137 137
Branches 29 29
=====================================
Hits 137 137Continue to review full report at Codecov.
|
|
i think, the two eslint-loader checks failed because of handbars , not this PR .
|
|
Updated 356c8e2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
changelog for
object-hash 2.0.0v2.0.1 fixes: puleos/object-hash#71
what i have done:
i am using vue-cli-plugin-electron-builder to build my electron appliaction and using this wonderful lib for logging purpose .
eslint-loader(2.2.1)andwinston-daily-rotate-file(4.3.0)useobject-hash 1.3.1, but i am stuck by issue puleos/object-hash#71so i manually replaced
node_modules/object-hash/dist/object_hash.jswith the latest version(2.0.1) and it works well.Breaking Changes
Only Node.js versions >= 6.0.0 are being tested in object-hash's CI now, so i think Node.js 6.0.0 or higher version is mandatory, but i'm not sure if this is a breaking change for eslint-loader
Additional Info