Skip to content
This repository was archived by the owner on Oct 27, 2020. It is now read-only.

perf: throw early if file doesn't exists #5

Merged
merged 1 commit into from
Jun 8, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 32 additions & 38 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,50 +66,44 @@ function pitch(remainingRequest, prevRequest, dataInput) {
const hash = digest(remainingRequest);
const cacheFile = path.join(cacheDirectory, `${hash}.json`);
data.cacheFile = cacheFile;
fs.exists(cacheFile, (exist) => {
if (!exist) {
fs.readFile(cacheFile, 'utf-8', (readFileErr, content) => {
if (readFileErr) {
callback();
return;
}
fs.readFile(cacheFile, 'utf-8', (readFileErr, content) => {
if (readFileErr) {
callback();
return;
}
data.fileExists = true;
let cacheData;
try {
cacheData = JSON.parse(content);
} catch (e) {
callback();
return;
}
if (cacheData.remainingRequest !== remainingRequest) {
// in case of a hash conflict
callback();
return;
}
async.each(cacheData.dependencies.concat(cacheData.contextDependencies), (dep, eachCallback) => {
fs.stat(dep.path, (statErr, stats) => {
if (statErr) {
eachCallback(statErr);
return;
}
if (stats.mtime.getTime() !== dep.mtime) {
eachCallback(true);
return;
}
eachCallback();
});
}, (err) => {
if (err) {
callback();
data.fileExists = true;
let cacheData;
try {
cacheData = JSON.parse(content);
} catch (e) {
callback();
return;
}
if (cacheData.remainingRequest !== remainingRequest) {
// in case of a hash conflict
callback();
return;
}
async.each(cacheData.dependencies.concat(cacheData.contextDependencies), (dep, eachCallback) => {
fs.stat(dep.path, (statErr, stats) => {
if (statErr) {
eachCallback(statErr);
return;
}
if (stats.mtime.getTime() !== dep.mtime) {
eachCallback(true);
return;
}
cacheData.dependencies.forEach(dep => this.addDependency(dep.path));
cacheData.contextDependencies.forEach(dep => this.addContextDependency(dep.path));
callback(null, ...cacheData.result);
eachCallback();
});
}, (err) => {
if (err) {
callback();
return;
}
cacheData.dependencies.forEach(dep => this.addDependency(dep.path));
cacheData.contextDependencies.forEach(dep => this.addContextDependency(dep.path));
callback(null, ...cacheData.result);
});
});
}
Expand Down