-
-
Notifications
You must be signed in to change notification settings - Fork 568
Allow lazy input object fields #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Resolves #911
Codecov Report
@@ Coverage Diff @@
## master #914 +/- ##
=========================================
Coverage 94.16% 94.16%
Complexity 50 50
=========================================
Files 117 117
Lines 9676 9684 +8
=========================================
+ Hits 9111 9119 +8
Misses 565 565
Continue to review full report at Codecov.
|
Thanks @spawnia , I'll try to test it out soon! |
Sorry, I can't seem to be able to test it.
is not updating my app correctly.
|
You would need this probably since it's not in master and you will need to "trick" it to fix other dependencies complaining: "webonyx/graphql-php": "dev-allow-lazy-input-object-fields as 14.9.0", |
@stayallive thanks! I didn't know that trick, this is great. @spawnia still trying to evaluate your change, thanks. This branch contains a fair amount of breaking changes (#906 and #830) that I'm trying to work around. I hope it will be back-ported to 14.x. |
Thanks, this is passing all our tests, and provide a small speed-up, so I'll take it :) |
Resolves #911
@stayallive @sebastienbarre