Skip to content

Allow lazy input object fields #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2021
Merged

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Aug 12, 2021

@spawnia spawnia requested a review from simPod August 12, 2021 16:05
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #914 (57165b8) into master (4518343) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #914   +/-   ##
=========================================
  Coverage     94.16%   94.16%           
  Complexity       50       50           
=========================================
  Files           117      117           
  Lines          9676     9684    +8     
=========================================
+ Hits           9111     9119    +8     
  Misses          565      565           
Impacted Files Coverage Δ
src/Type/Definition/InputObjectType.php 93.61% <100.00%> (+1.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4518343...57165b8. Read the comment docs.

@sebastienbarre
Copy link

Thanks @spawnia , I'll try to test it out soon!

@sebastienbarre
Copy link

sebastienbarre commented Aug 16, 2021

Sorry, I can't seem to be able to test it.

    "webonyx/graphql-php": "dev-master",

is not updating my app correctly.

composer upgrade webonyx/graphql-php                                         
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - mll-lab/graphql-php-scalars is locked to version v3.1.0 and an update of this package was not requested.
    - mll-lab/graphql-php-scalars v3.1.0 requires webonyx/graphql-php ^0.13.8 || ^14.0.0 -> found webonyx/graphql-php[v0.13.8, v0.13.9, 0.13.x-dev, v14.0.0, ..., 14.x-dev] but it conflicts with your root composer.json require (dev-master).

@stayallive
Copy link
Contributor

You would need this probably since it's not in master and you will need to "trick" it to fix other dependencies complaining:

	"webonyx/graphql-php": "dev-allow-lazy-input-object-fields as 14.9.0",

@sebastienbarre
Copy link

sebastienbarre commented Aug 16, 2021

@stayallive thanks! I didn't know that trick, this is great.

@spawnia still trying to evaluate your change, thanks. This branch contains a fair amount of breaking changes (#906 and #830) that I'm trying to work around. I hope it will be back-ported to 14.x.

@sebastienbarre
Copy link

Thanks, this is passing all our tests, and provide a small speed-up, so I'll take it :)

@spawnia spawnia merged commit cf5e6fd into master Sep 6, 2021
@spawnia spawnia deleted the allow-lazy-input-object-fields branch September 6, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazy field definitions not working for Input types
4 participants