Skip to content

[WIP][0.13] Separate multiple inherited interfaces with & #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WIP][0.13] Separate multiple inherited interfaces with & #237

wants to merge 1 commit into from

Conversation

danez
Copy link
Contributor

@danez danez commented Feb 8, 2018

This replaces:

type Foo implements Bar, Baz { field: Type }

With:

type Foo implements Bar & Baz { field: Type }

With no changes to the common case of implementing a single interface.

This is a breaking change for existing uses of multiple inheritence. To allow for an adaptive migration, this adds a parse option to continue to support the existing experimental SDL: parse(source, {allowLegacySDLImplementsInterfaces: true})

Ref: graphql/graphql-js#1169

This replaces:

```graphql
type Foo implements Bar, Baz { field: Type }
```

With:

```graphql
type Foo implements Bar & Baz { field: Type }
```

With no changes to the common case of implementing a single interface.

Ref: graphql/graphql-js#1169
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 92.834% when pulling b842957 on danez:013-interfaces into 94525c0 on webonyx:master.

@danez danez changed the title [0.13] Separate multiple inherited interfaces with & [WIP][0.13] Separate multiple inherited interfaces with & Feb 16, 2018
@vladar
Copy link
Member

vladar commented Mar 29, 2018

As far as I understand this PR doesn't make sense as a standalone PR anymore? Or am I missing something?

@danez
Copy link
Contributor Author

danez commented Apr 4, 2018

This is not included in the other big PR as the other PR was only adding stuff up to 0.12.3, and this is part of 0.13. But i guess i will create a new PR at some point with all the 0.13 changes.

@vladar
Copy link
Member

vladar commented Aug 20, 2018

I already ported this as a part of the work on v0.13

@vladar vladar closed this Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants