Store introspection field definitions as property

Since the ReferenceExecutor is an instance, we can keep this cache on the instance. Great!
webonyx · Nov 11, 2024 · 07d754d · 07d754d
1 parent 9954572
commit 07d754d
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/src/Executor/ReferenceExecutor.php b/src/Executor/ReferenceExecutor.php
@@ -69,6 +69,10 @@ class ReferenceExecutor implements ExecutorImplementation
      */
     protected \SplObjectStorage $fieldArgsCache;
 
+    protected FieldDefinition $schemaMetaFieldDef;
+    protected FieldDefinition $typeMetaFieldDef;
+    protected FieldDefinition $typeNameMetaFieldDef;
+
     protected function __construct(ExecutionContext $context)
     {
         if (! isset(static::$UNDEFINED)) {
@@ -701,23 +705,22 @@ protected function resolveField(
      */
     protected function getFieldDef(Schema $schema, ObjectType $parentType, string $fieldName): ?FieldDefinition
     {
-        static $schemaMetaFieldDef, $typeMetaFieldDef, $typeNameMetaFieldDef;
-        $schemaMetaFieldDef ??= Introspection::schemaMetaFieldDef();
-        $typeMetaFieldDef ??= Introspection::typeMetaFieldDef();
-        $typeNameMetaFieldDef ??= Introspection::typeNameMetaFieldDef();
+        $this->schemaMetaFieldDef ??= Introspection::schemaMetaFieldDef();
+        $this->typeMetaFieldDef ??= Introspection::typeMetaFieldDef();
+        $this->typeNameMetaFieldDef ??= Introspection::typeNameMetaFieldDef();
 
         $queryType = $schema->getQueryType();
 
-        if ($fieldName === $schemaMetaFieldDef->name && $queryType === $parentType) {
-            return $schemaMetaFieldDef;
+        if ($fieldName === $this->schemaMetaFieldDef->name && $queryType === $parentType) {
+            return $this->schemaMetaFieldDef;
         }
 
-        if ($fieldName === $typeMetaFieldDef->name && $queryType === $parentType) {
-            return $typeMetaFieldDef;
+        if ($fieldName === $this->typeMetaFieldDef->name && $queryType === $parentType) {
+            return $this->typeMetaFieldDef;
         }
 
-        if ($fieldName === $typeNameMetaFieldDef->name) {
-            return $typeNameMetaFieldDef;
+        if ($fieldName === $this->typeNameMetaFieldDef->name) {
+            return $this->typeNameMetaFieldDef;
         }
 
         return $parentType->findField($fieldName);