This repository was archived by the owner on Oct 22, 2024. It is now read-only.
Fixed computed output shape of matmul op. #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingmingtasd
left a comment
mingmingtasd
left a comment
There was a problem hiding this comment.
LGTM. But there is no test case to cover and validate, should we add more?
Collaborator
Author
|
Hi @mingmingtasd, I caught this issue by this new mamul 3D x 1D test for WPT. |
BruceDai
force-pushed
the
fix_matmul_outputshape
branch
2 times, most recently
from
a82de2f to
fe6aff2
Compare
Collaborator
Author
|
@mingmingtasd Updated, please take another look, thanks. |
BruceDai
force-pushed
the
fix_matmul_outputshape
branch
from
fe6aff2 to
22fe520
Compare
BruceDai
force-pushed
the
fix_matmul_outputshape
branch
from
22fe520 to
b46181d
Compare
mingmingtasd
approved these changes
Nov 24, 2022
Collaborator
Author
|
Thanks @mingmingtasd for reviewing, I will merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mingmingtasd PTAL, and there's the same issue for webnn-native: https://github.com/webmachinelearning/webnn-native/blob/main/src/webnn/native/ops/Binary.cpp#L57, please help fix it, thanks.