Skip to content

Add ninja in DEPS #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Add ninja in DEPS #394

merged 1 commit into from
Apr 6, 2023

Conversation

mingmingtasd
Copy link
Collaborator

Fix #393. Update DEPS to align with chromium's DEPS, otherwise, ninja will fail. PTAL, thanks! @fujunwei @huningxin

@BruceDai
Copy link
Collaborator

BruceDai commented Apr 4, 2023

Thanks @mingmingtasd to fix this issue.
These CI failures are due to fail build main branch to get baseline for regression check with the same fixing issue.
@fujunwei I suggest merge it directly.

@fujunwei
Copy link
Collaborator

fujunwei commented Apr 6, 2023

I can't merge it because the button of "Merge pull request" is disabled on my side.

@anssiko
Copy link
Member

anssiko commented Apr 6, 2023

I had a discussion with @BruceDai about this PR. I'll merge this without waiting for all the checks to be successful.

@anssiko anssiko merged commit 8a090c2 into webmachinelearning:main Apr 6, 2023
@BruceDai
Copy link
Collaborator

BruceDai commented Apr 6, 2023

Thanks @anssiko to help merge it.
I will investigate configurations for fixing such case.

@mingmingtasd
Copy link
Collaborator Author

Thanks! @anssiko @BruceDai @fujunwei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ninja failed: Could not find Ninja in the third_party of the current project, nor in your PATH.
4 participants