Implement prelu #35
Merged
Implement prelu #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdwr
approved these changes
Mar 9, 2023
| */ | ||
| export function prelu(x, slope) { | ||
| const zero = new Tensor([1], [0]); | ||
| return add(max(zero, x), mul(slope, min(zero, x))); |
There was a problem hiding this comment.
Interesting way of expressing it. I like that you can compose it from simpler operators. Also, this handles any broadcasting automatically for you because mul handles it.
test/prelu_test.js
Outdated
| 'shape': [1, 2, 3], | ||
| 'data': [ | ||
| 1, -0.1, 2, | ||
| -0.2, 3, -0.30000000000000004, |
There was a problem hiding this comment.
Consider using 0.125 rather than 0.1 if you want exact answers.
Contributor
Author
There was a problem hiding this comment.
@fdwr Thanks. I've updated tests, please have another look.
fdwr
approved these changes
Mar 14, 2023
huningxin
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@huningxin @fdwr PTAL, thanks.