[WIP] generate test data for WebNN matmul tests of WPT #23
Conversation
| @@ -0,0 +1,17 @@ | |||
| # Introduction | |||
| These Node.js scripts `gen-<operation-name>.js` in this `tool` folder are used to gerenate / update test data which would be involved into test data JSON files for WebNN operations tests of web-platform-tests project. | |||
| * @param {String} precisionType | ||
| * @return {Array<Number>} | ||
| */ | ||
| function getPrecisionData(input, precisionType) { |
There was a problem hiding this comment.
Name sounds odd, because it sounds like it's getting information about the precision itself, rather than casting the data to a given precision. How about getDataCastToPrecision or even clearer castDataToPrecision?
| } else { | ||
| const targetDataInfo = inputsDataInfo[source]; | ||
| if (targetDataInfo.data !== undefined) { | ||
| const permutation = targetDataInfo.transpose; |
There was a problem hiding this comment.
Hmm, what is transpose used for? Advise a comment here.
| if (path.isAbsolute(filePath)) { | ||
| inputFile = filePath; | ||
| } else { | ||
| inputFile = |
There was a problem hiding this comment.
[minor] Unwrap line? (it's only 67 characters wide)
| // If found, it replaces it by a trio | ||
| if ( value instanceof Int8Array || | ||
| value instanceof Uint8Array || | ||
| value instanceof Uint16Array || |
There was a problem hiding this comment.
WebNN doesn't have either uint16 or int16. https://webmachinelearning.github.io/webnn/#enumdef-mloperandtype So, should we remove Uint16Array?
BruceDai
changed the title
|
Has this CR already been superseded by newer ones? |
Yes. This PR is earlier version, let me close it and will submit new version, thanks. |
2 participants
@huningxin @fdwr PTAL, thanks.