Skip to content

fix(app-headless-cms): refresh revision list after create/delete - #5614

Merged
brunozoric merged 1 commit into
bruno/fix/6.5.0/svens-notesfrom
bruno/fix/6.5.0/app-headless-cms/revision-cache
Aug 28, 2026
Merged

brunozoric merged 1 commit into
bruno/fix/6.5.0/svens-notesfrom
bruno/fix/6.5.0/app-headless-cms/revision-cache

Conversation

@brunozoric

Copy link
Copy Markdown
Contributor

Summary

  • Revision list refresh: After creating or deleting a revision, the revisions drawer now re-fetches the list from the API. Previously, the list stayed stale until the drawer was closed and reopened.
  • Delete confirmation fix: The delete confirmation check used !confirmed which treated the dialog's undefined resolve as a cancellation. Changed to confirmed === false since onCancel explicitly resolves with false,
    while onConfirm() (called with no data) resolves with undefined.

Test plan

  • Unit tests added for RevisionsListPresenter covering:
    • List refreshes after successful create
    • List refreshes after successful delete
    • No refresh on create/delete failure
    • No delete when confirmation is declined
    • Dispose clears all state
  • Manual: open a content entry → open revisions drawer → create a new revision → verify the list updates immediately
  • Manual: open revisions drawer → delete a draft revision → confirm → verify it's actually deleted and the list updates

…fix delete confirmation

Revision list now re-fetches after creating or deleting a revision.
Delete confirmation check changed from falsy to strict `=== false`
since the dialog resolves with `undefined` on confirm, not `true`.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@brunozoric brunozoric added this to the 6.5.0 milestone Aug 28, 2026
@brunozoric brunozoric self-assigned this Aug 28, 2026
@brunozoric brunozoric changed the title fix(app-headless-cms): refresh revision list after create/delete and … fix(app-headless-cms): refresh revision list after create/delete Aug 28, 2026
@brunozoric
brunozoric changed the base branch from release/6.5.0 to bruno/fix/6.5.0/svens-notes August 28, 2026 10:45
@brunozoric
brunozoric marked this pull request as ready for review August 28, 2026 10:45
@brunozoric
brunozoric merged commit 83554d3 into bruno/fix/6.5.0/svens-notes Aug 28, 2026
17 checks passed
@Pavel910
Pavel910 deleted the bruno/fix/6.5.0/app-headless-cms/revision-cache branch September 8, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant