Repository navigation
feat: upgrade to react 18 - fix build #3 - #3779
Merged
brunozoric merged 3 commits intoJan 2, 2024
Merged
Conversation
brunozoric
reviewed
Dec 21, 2023
| * Register a new menu item into the Admin app. | ||
| */ | ||
| export const AddMenu = ({ children, ...props }: MenuProps) => { | ||
| export const AddMenu = ({ children, ...props }: React.PropsWithChildren<MenuProps>) => { |
Contributor
There was a problem hiding this comment.
Avoid using React.PropsWithChildren when possible. Write type with children defined.
neatbyte-vnobis
force-pushed
the
neatbyte/react-18-build-3
branch
from
December 21, 2023 12:46
1d2d4ad to
9441ff6
Compare
brunozoric
approved these changes
Dec 21, 2023
brunozoric
approved these changes
Dec 21, 2023
brunozoric
pushed a commit
that referenced
this pull request
Jan 11, 2024
brunozoric
pushed a commit
that referenced
this pull request
Jan 12, 2024
brunozoric
pushed a commit
that referenced
this pull request
Jan 17, 2024
brunozoric
pushed a commit
that referenced
this pull request
Feb 6, 2024
brunozoric
pushed a commit
that referenced
this pull request
Feb 14, 2024
brunozoric
pushed a commit
that referenced
this pull request
Feb 15, 2024
brunozoric
pushed a commit
that referenced
this pull request
Mar 13, 2024
brunozoric
pushed a commit
that referenced
this pull request
Mar 18, 2024
brunozoric
pushed a commit
that referenced
this pull request
Mar 28, 2024
brunozoric
pushed a commit
that referenced
this pull request
May 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Third batch of fixes for project build after updating to react 18.
https://www.notion.so/webiny/Upgrade-to-React-18-ceacd9bbfcf74b39a7ceb70943c3afa7
Packages: app-admin, app-form-builder
How Has This Been Tested?
Manually.
Documentation
None.