Minor cleanup to keep inline with Dawn's headers. #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lokokung
commented
May 7, 2025
lokokung
commented
- Updates sorting to take into account extensions and ignore type name casing.
- Updates some comments to use helpers and cleans up some whitespace.
- Moves WGPU_STRLEN into a constant.
- Updates sorting to take into accound extensions and ignore type name casing. - Updates some comments to use helpers and cleans up some whitespace. - Moves WGPU_STRLEN into a constant.
kainino0x
approved these changes
May 8, 2025
| @@ -131,15 +131,9 @@ | |||
| * For info on how this is used in various places, see \ref Strings. | |||
| */ | |||
| typedef struct WGPUStringView { | |||
| char const * WGPU_NULLABLE data; | |||
There was a problem hiding this comment.
note: I have this here because it's where we want it to be eventually: http://github.com/webgpu-native/webgpu-headers/issues/190
and since it's not autogenerated it won't get fixed along with everything else when we finally fix it.
But I guess it doesn't matter, once we do that we'll actually test it (set the macro and compile test) and presumably we'll find this again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.