Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drawer): add support for title, header-actions and footer slots #473

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

hyyan
Copy link
Member

@hyyan hyyan commented Jan 8, 2024

@MatthewHawkins please update the drawer docs, the PR:

  1. Remove style methods (setSize and setMaxWidth). Css variables must be used for this (Keep the current docs, just explain the way to do it in css variables)
  2. Add support for the title, header-actions and footer slots
public class DrawerDemo extends App {

  Drawer drawer = new Drawer("Drawer");
  Element title = new Element("p", "This is a Drawer component!");
  Button button = new Button("Click me!");

  @Override
  public void run() throws DwcjException {

    Frame app = new Frame();
    app.add(drawer);

    drawer.open();
    drawer.add(title);
    drawer.addToFooter(button.setTheme(ButtonTheme.PRIMARY));
  }
}
drawer

@hyyan hyyan added this to the 23.06 milestone Jan 8, 2024
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hyyan hyyan merged commit a29ac49 into main Jan 8, 2024
10 checks passed
@hyyan hyyan deleted the drawer-footer-header branch January 8, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant