docs: Update Login component documentation for 25.10 features #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document action property and custom fields, improve overall clarity and tone
laurenic0l
requested review from
MatthewHawkins,
bbrennanbasis,
gosteenBASIS and
hyyan
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hyyan
approved these changes
Oct 21, 2025
bbrennanbasis
requested changes
Oct 21, 2025
There was a problem hiding this comment.
@laurenic0l added my changes and left some comments. For future reference, when writing about UI buttons, use brackets and the capitalization as shown on the button. For example, clicking the [Sign in] button does.....
|
|
||
| login.onSubmit(ev -> { | ||
| String id = customerId.getValue(); | ||
| String id = (String) ev.getData().get("customer-id"); |
There was a problem hiding this comment.
We'll need to update the project to use 25.10 or the 25.10 snapshot before merging this PR. If we don't, the program will crash since getting values this way isn't implemented in 25.03.
| password.equals("admin") && | ||
| id.equals("Tesla")) { | ||
| login.close(); | ||
| getBoundComponent().add(new Button("Logout", e -> Page.getCurrent().reload())); |
There was a problem hiding this comment.
Add spacing to the [Logout] button, or make it centered. As it stands currently, it can be easily missed if the demo isn't in full view:
It wouldn't hurt to also add the same fix to LoginBasicView.java.
MatthewHawkins
approved these changes
Oct 22, 2025
hyyan
added
status: needs-snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document action property and custom fields, improve overall clarity and tone
closes #600