Datefield enhancements. #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EHandtkeBasis
requested review from
hyyan,
MatthewHawkins,
nmlynx and
mschned
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| The `DateField` component stores its value internally as a `LocalDate` object, representing a date without time or timezone information. This allows for accurate handling of calendar-based input across different systems. | ||
|
|
||
| While the **visual display adapts to the user's browser locale**, ensuring regionally familiar formatting (e.g., MM/DD/YYYY in the USA or DD.MM.YYYY in Europe), the internal parsing and programmatic interaction always rely on the fixed format: **`yyyy-MM-dd`**. |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Acronyms] Spell out 'YYYY', if it's unfamiliar to the audience.
|
|
||
| The `DateField` component stores its value internally as a `LocalDate` object, representing a date without time or timezone information. This allows for accurate handling of calendar-based input across different systems. | ||
|
|
||
| While the **visual display adapts to the user's browser locale**, ensuring regionally familiar formatting (e.g., MM/DD/YYYY in the USA or DD.MM.YYYY in Europe), the internal parsing and programmatic interaction always rely on the fixed format: **`yyyy-MM-dd`**. |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Acronyms] Spell out 'USA', if it's unfamiliar to the audience.
|
|
||
| The `DateField` component stores its value internally as a `LocalDate` object, representing a date without time or timezone information. This allows for accurate handling of calendar-based input across different systems. | ||
|
|
||
| While the **visual display adapts to the user's browser locale**, ensuring regionally familiar formatting (e.g., MM/DD/YYYY in the USA or DD.MM.YYYY in Europe), the internal parsing and programmatic interaction always rely on the fixed format: **`yyyy-MM-dd`**. |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Acronyms] Spell out 'YYYY', if it's unfamiliar to the audience.
This was
linked to
issues
May 15, 2025
MatthewHawkins
requested changes
May 20, 2025
MatthewHawkins
previously approved these changes
May 27, 2025
|
/rebase |
github-actions
bot
force-pushed
the
datefield-enhancement
branch
from
693356d to
987ae30
Compare
- Removed "Localized display" section (last bullet point in Issue 58) - Created subsection titles for "Min and max value" - Put all date formats into code styling - Added "Updated" tag to the sidebar - Changed tip about `IllegalArgumentException` to a warning
bbrennanbasis
force-pushed
the
datefield-enhancement
branch
from
987ae30 to
8c6998b
Compare
bbrennanbasis
approved these changes
Jun 23, 2025
hyyan
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#57
#58