-
Notifications
You must be signed in to change notification settings - Fork 0
Added section for appdrawertoggle, drawer actions and drawer title in the applayout documentation. #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Relying on #299 to be merged first for final revision. |
80b9373
to
2227a11
Compare
@MatthewHawkins please give it a quick read over for language/style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EHandtkeBasis I've left some review comments. Additional, please rebase the branch and resolve the merge conflicts.
docs/docs/components/app-layout.md
Outdated
## Drawer breakpoint | ||
|
||
Be default, when the screen width is 800px or less , the drawer will be switched to popover mode. This is called the breakpoint. Popover mode means that the drawer will pop over the content area with an overlay. It is possible to configure the breakpoint by using the DwcAppLayout:setDrawerBreakpoint method and the breakpoint must be a valid media query. | ||
Be default, when the screen width is 800px or less , the drawer will be switched to popover mode. This is called the breakpoint. Popover mode means that the drawer will pop over the content area with an overlay. It's possible to configure the breakpoint by using the DwcAppLayout:setDrawerBreakpoint method and the breakpoint must be a valid media query. | ||
|
||
For instance, in the following sample. we configure the drawer breakpoint to be 500px or less. | ||
For instance, in the following sample the drawer breakpoint is configured to be 500px or less. | ||
|
||
```java | ||
AppLayout demo = new AppLayout(); | ||
demo.setDrawerBreakpoint("(max-width:500px)"); | ||
``` | ||
|
||
<AppLayoutViewer path='/webforj/applayoutmobiledrawer/?' mobile='true' | ||
<!-- <AppLayoutViewer path='/webforj/applayoutmobiledrawer/?' mobile='true' | ||
javaE='https://raw.githubusercontent.com/webforj/webforj-documentation/refs/heads/main/src/main/java/com/webforj/samples/views/applayout/AppLayoutMobileDrawerView.java' | ||
cssURL='https://raw.githubusercontent.com/webforj/webforj-documentation/main/src/main/resources/css/applayout/applayoutMobile.css' | ||
/> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to be a sub section under Drawer utilities.
docs/docs/components/app-layout.md
Outdated
javaE='https://raw.githubusercontent.com/webforj/webforj-documentation/refs/heads/main/src/main/java/com/webforj/samples/views/applayout/AppLayoutMobileDrawerView.java' | ||
cssURL='https://raw.githubusercontent.com/webforj/webforj-documentation/main/src/main/resources/css/applayout/applayoutMobile.css' | ||
/> --> | ||
|
||
## Drawer utilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Add a sentence here distinguishing the drawer utility inside the AppLayout
component vs the standalone Drawer
component.
...a/com/webforj/samples/views/applayout/applayoutdrawerutility/AppLayoutDrawerUtilityView.java
Show resolved
Hide resolved
docs/docs/components/app-layout.md
Outdated
<AppLayoutViewer path='/webforj/applayoutfullnavbar/content/Dashboard?' mobile='false' | ||
javaE='https://raw.githubusercontent.com/webforj/webforj-documentation/refs/heads/main/src/main/java/com/webforj/samples/views/applayout/fullnavbar/AppLayoutFullNavbarView.java' | ||
cssURL='https://raw.githubusercontent.com/webforj/webforj-documentation/main/src/main/resources/css/applayout/applayout.css'/> | ||
|
||
|
||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove each -->
from previously commented out examples.
docs/docs/components/app-layout.md
Outdated
|
||
### Drawer actions | ||
|
||
The `AppLayout` component allows you to place custom components such as buttons or icons into the **drawer header actions area** using the `addToDrawerHeaderActions(...)` method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use ellipsis inside the methods -> addToDrawerHeaderActions()
docs/docs/components/app-layout.md
Outdated
|
||
Be default, when the screen width is 800px or less , the drawer will be switched to popover mode. This is called the breakpoint. Popover mode means that the drawer will pop over the content area with an overlay. It is possible to configure the breakpoint by using the DwcAppLayout:setDrawerBreakpoint method and the breakpoint must be a valid media query. | ||
The AppLayout drawer utility is designed for integrated navigation and contextual menus within the main app layout, while standalone Drawer components offer flexible, independent sliding panels that can be used anywhere in your app for additional content, filters, or notifications. This section focuses on the built-in drawer features and utilities provided by AppLayout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put AppLayout
and Drawer
in code brackets. Also, link to the Drawer
article: https://docs.webforj.com/docs/components/drawer
|
||
<AppLayoutViewer path='/webforj/applayoutmobiledrawer/?' mobile='true' | ||
javaE='https://raw.githubusercontent.com/webforj/webforj-documentation/refs/heads/main/src/main/java/com/webforj/samples/views/applayout/mobiledrawer/AppLayoutMobileDrawerView.java' | ||
cssURL='https://raw.githubusercontent.com/webforj/webforj-documentation/main/src/main/resources/css/applayout/applayoutMobile.css' | ||
### Drawer title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the AppLayoutMobileDrawerView
java class file if this example is no longer used in the articles.
cf97047
to
a315fda
Compare
No description provided.