-
Couldn't load subscription status.
- Fork 0
Implemented spring implementation. #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to update all READMEs and either update or remove all test classes depending on your plans with them.
| @@ -0,0 +1,106 @@ | |||
| # DemoApplication | |||
|
|
|||
| A webforJ application powered by Spring Boot. This project combines the power of webforJ framework with Spring Boot's comprehensive ecosystem for building enterprise applications. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project combines webforJ's front end framework with Spring Boot's...
|
|
||
| ### Spring Boot Features | ||
|
|
||
| This project leverages Spring Boot's features: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project demonstrates the following Spring Boot features:
| Your application will automatically restart when files on the classpath change. | ||
|
|
||
|
|
||
| ## Running Integration Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to include tests for each step? If not, remove this section.
| @@ -0,0 +1,55 @@ | |||
| package com.demoapplication.views; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either update the test to reflect current app, or remove.
spring/2-working-with-data/README.md
Outdated
|
|
||
| ### Spring Boot Features | ||
|
|
||
| This project leverages Spring Boot's features: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to the same as the correction in step 1's README
|
|
||
| @Repository | ||
| public interface CustomerRepository extends JpaRepository<Customer, Long>, JpaSpecificationExecutor<Customer> { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyyan is going to love this empty space ;)
| @@ -0,0 +1,55 @@ | |||
| package com.demoapplication.views; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove if not being updated
| public DemoView(CustomerService customerService) { | ||
| this.customerService = customerService; | ||
|
|
||
| add.setStyle("margin", "var(--dwc-space-l)").setWidth(200); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a classname and move this styling to the CSS file
| } | ||
|
|
||
| @Override | ||
| public void onDidEnter(DidEnterEvent event, ParametersBag parameters) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forget why we use the observer here instead of putting this in the constructor? If that is in fact necessary, let's make sure to specify why in the documentation page created for this section.
| TextField lastName = new TextField("Last Name"); | ||
| TextField company = new TextField("Company"); | ||
| ChoiceBox country = new ChoiceBox("Country"); | ||
| TextField firstName = new TextField("First Name", e -> customer.setFirstName(e.getValue())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't need to manually set the info if you're using data binding
No description provided.