Skip to content

Replace gulp-clean-css with gulp-csso (Case 161784) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Replace gulp-clean-css with gulp-csso (Case 161784) #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions config/postcss-plugins-default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,6 @@ function postCssPlugins(config, stylesheet) {
let purgeCss = purgeCssConfig && !purgeCssDisabled;

return [
$.autoprefixer(),
$.postcssurl({
url: function (asset) {
if (!asset.url || asset.url.indexOf("base64") !== -1) {
return asset.url;
}
return $.path.relative(`${config.webdir}/${stylesheet.destDir}/`, asset.absolutePath).split("\\").join("/");
}
}),
// conditionally run PurgeCSS if any config (local or global) was found
purgeCss ? $.purgecss({
content: purgeCssConfig.content,
Expand All @@ -38,7 +29,16 @@ function postCssPlugins(config, stylesheet) {
}
],
safelist: purgeCssConfig.safelist
}) : false
}) : false,
$.postcssurl({
url: function (asset) {
if (!asset.url || asset.url.indexOf("base64") !== -1) {
return asset.url;
}
return $.path.relative(`${config.webdir}/${stylesheet.destDir}/`, asset.absolutePath).split("\\").join("/");
}
}),
$.autoprefixer(),
].filter(Boolean); // Strip falsy values (this enables conditional plugins like PurgeCSS)
}

Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"gulp-babel": "^8.0.0",
"gulp-clean-css": "github:webfactory/gulp-clean-css",
"gulp-concat": "^2.3.3",
"gulp-csso": "^4.0.1",
"gulp-load-plugins": "^2.0.1",
"gulp-postcss": "^9.0.0",
"gulp-sass": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion tasks/styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function styles(gulp, $, config) {
}).on('error', $.sass.logError))
.pipe($.postcss(config.styles.postCssPlugins(config, stylesheet)))
.pipe($.concat(stylesheet.name))
.pipe($.cleanCss({ compatibility: 'ie11' }))
.pipe($.csso({ sourceMap: true }))
.pipe(config.development ? $.sourcemaps.write('.') : $.through2.obj())
.pipe(gulp.dest(`${config.webdir}/${stylesheet.destDir}`))
.pipe($.browserSync.reload({ stream: true }));
Expand Down