Resolve to current major version of clean-css (Case 146359) #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Yarn resolution in package.json to require the current major version of clean-css (unfortunately, gulp-clean-css seems to be dead with the pertinent PR remaining unmerged since 2021). clean-css 5.3.2 includes a fix that enables us to use conainer queries without losing them to CSS minification. We no longer need to disable URL rebasing as the new default is `false`. This seems to be a good time to bump compatibility up to ie11 (the default is >11 which is still a bit too strict for us in 2023).
polarbirke
changed the title
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Yarn resolution in package.json to require the current
major version of clean-css (unfortunately, gulp-clean-css seems
to be dead with the pertinent PR remaining unmerged since 2021).
clean-css 5.3.2 includes a fix that enables us to use conainer
queries without losing them to CSS minification.
We no longer need to disable URL rebasing as the new default
is
false.This seems to be a good time to bump compatibility up to ie11 (the
default is >11 which is still a bit too strict for us in 2023).