Skip to content

Comments

fix: added new entry points in secrets and pullrequest#630

Open
rsarika wants to merge 1 commit intowebex:nextfrom
rsarika:pull-request-fix
Open

fix: added new entry points in secrets and pullrequest#630
rsarika wants to merge 1 commit intowebex:nextfrom
rsarika:pull-request-fix

Conversation

@rsarika
Copy link
Contributor

@rsarika rsarika commented Feb 24, 2026

COMPLETES

N/A

This pull request addresses

The pull-request GitHub Actions workflow only exposed PW_ENTRY_POINT1 through PW_ENTRY_POINT8 in env, which left additional configured entry point secrets unavailable to PR jobs.

by making the following changes

  • Added PW_ENTRY_POINT9, PW_ENTRY_POINT10, PW_ENTRY_POINT11, and PW_ENTRY_POINT12 to .github/workflows/pull-request.yml
  • Kept the existing env wiring pattern (${{ secrets.<NAME> }}) consistent with entry points 1–8

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
  • Verified workflow file update for correct secret-to-env mapping for PW_ENTRY_POINT1 through PW_ENTRY_POINT12
  • No runtime application code paths were changed (CI workflow configuration only)

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • GAI was used to create a draft that was subsequently customized or modified
  • Code was generated entirely by GAI
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify (Codex)
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-630.d1b38q61t1z947.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant